From 6845e400cdb37fffb715e0e1e59c72743c33a2e5 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Wed, 12 Dec 2018 16:06:03 +0100 Subject: [PATCH] uru4000: Fix memory leak on error in dev_init() libfprint/drivers/uru4000.c:1357:3: warning: Potential leak of memory pointed to by 'urudev' fp_err("could not get encryption slot"); ^~~~~~ --- libfprint/drivers/uru4000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libfprint/drivers/uru4000.c b/libfprint/drivers/uru4000.c index 94973858..7830c562 100644 --- a/libfprint/drivers/uru4000.c +++ b/libfprint/drivers/uru4000.c @@ -1348,6 +1348,8 @@ static int dev_init(struct fp_img_dev *dev, unsigned long driver_data) } urudev = g_malloc0(sizeof(*urudev)); + fp_dev_set_instance_data(FP_DEV(dev), urudev); + urudev->profile = &uru4k_dev_info[driver_data]; urudev->interface = iface_desc->bInterfaceNumber; @@ -1374,7 +1376,6 @@ static int dev_init(struct fp_img_dev *dev, unsigned long driver_data) } urudev->param = PK11_ParamFromIV(urudev->cipher, NULL); - fp_dev_set_instance_data(FP_DEV(dev), urudev); fpi_imgdev_open_complete(dev, 0); out: