From b890fa56d806cc0f3c52a9e67c8b20b688b8ecac Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Wed, 26 Sep 2018 16:23:41 +0200 Subject: [PATCH] aes1610: Use constants for buffer sizes --- libfprint/drivers/aes1610.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libfprint/drivers/aes1610.c b/libfprint/drivers/aes1610.c index 5818ad4e..1e7b3b9b 100644 --- a/libfprint/drivers/aes1610.c +++ b/libfprint/drivers/aes1610.c @@ -44,6 +44,9 @@ static int adjust_gain(unsigned char *buffer, int status); #define BULK_TIMEOUT 4000 +#define FINGER_DETECTION_LEN 19 +#define STRIP_CAPTURE_LEN 665 + /* * The AES1610 is an imaging device using a swipe-type sensor. It samples * the finger at preprogrammed intervals, sending a 128x8 frame to the @@ -220,8 +223,8 @@ static void finger_det_reqs_cb(struct fp_img_dev *dev, int result, void *user_da } transfer = fpi_usb_alloc(); - data = g_malloc(19); - libusb_fill_bulk_transfer(transfer, fpi_dev_get_usb_dev(FP_DEV(dev)), EP_IN, data, 19, + data = g_malloc(FINGER_DETECTION_LEN); + libusb_fill_bulk_transfer(transfer, fpi_dev_get_usb_dev(FP_DEV(dev)), EP_IN, data, FINGER_DETECTION_LEN, finger_det_data_cb, dev, BULK_TIMEOUT); r = libusb_submit_transfer(transfer); @@ -645,7 +648,7 @@ static void capture_run_state(fpi_ssm *ssm, struct fp_dev *_dev, void *user_data break; case CAPTURE_READ_DATA: fp_dbg("read data"); - generic_read_ignore_data(ssm, _dev, 665); + generic_read_ignore_data(ssm, _dev, STRIP_CAPTURE_LEN); break; case CAPTURE_REQUEST_STRIP: fp_dbg("request strip"); @@ -659,8 +662,8 @@ static void capture_run_state(fpi_ssm *ssm, struct fp_dev *_dev, void *user_data struct libusb_transfer *transfer = fpi_usb_alloc(); unsigned char *data; - data = g_malloc(665); - libusb_fill_bulk_transfer(transfer, fpi_dev_get_usb_dev(FP_DEV(dev)), EP_IN, data, 665, + data = g_malloc(STRIP_CAPTURE_LEN); + libusb_fill_bulk_transfer(transfer, fpi_dev_get_usb_dev(FP_DEV(dev)), EP_IN, data, STRIP_CAPTURE_LEN, capture_read_strip_cb, ssm, BULK_TIMEOUT); r = libusb_submit_transfer(transfer);