mirrors/libfprint
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libfprint/libfprint.git synced 2026-09-10 13:00:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

upektc_img: Cleanup image bits on deactivation

Browse Source 
Also ensure we never leak data
This commit is contained in:
Marco Trevisan (Treviño)
2026-07-13 08:13:46 +00:00
committed by Marco Trevisan
parent 44dd97bf5e
commit ecbc2affb2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libfprint/drivers/upektc_img.c
+3 -3
View File
@@ -432,12 +432,10 @@ capture_run_state (FpiSsm *ssm, FpDevice *_dev)
static void static void
capture_sm_complete (FpiSsm *ssm, FpDevice *_dev, GError *error_arg) capture_sm_complete (FpiSsm *ssm, FpDevice *_dev, GError *error_arg)
{ {
g_autoptr(GError) error = error_arg;
FpImageDevice *dev = FP_IMAGE_DEVICE (_dev); FpImageDevice *dev = FP_IMAGE_DEVICE (_dev);
FpiDeviceUpektcImg *self = FPI_DEVICE_UPEKTC_IMG (_dev); FpiDeviceUpektcImg *self = FPI_DEVICE_UPEKTC_IMG (_dev);
g_autoptr(GError) error = error_arg;
/* Note: We assume that the error is a cancellation in the deactivation case */ /* Note: We assume that the error is a cancellation in the deactivation case */
if (self->deactivating) if (self->deactivating)
start_deactivation (dev); start_deactivation (dev);
@@ -518,6 +516,7 @@ deactivate_sm_complete (FpiSsm *ssm, FpDevice *_dev, GError *error)
fp_dbg ("Deactivate completed"); fp_dbg ("Deactivate completed");
g_clear_pointer (&self->image_bits, g_free);
self->deactivating = FALSE; self->deactivating = FALSE;
fpi_image_device_deactivate_complete (dev, error); fpi_image_device_deactivate_complete (dev, error);
} }
@@ -632,6 +631,7 @@ init_read_data_cb (FpiUsbTransfer *transfer, FpDevice *device,
} }
self->expected_image_size = img_class->img_width * img_class->img_height; self->expected_image_size = img_class->img_width * img_class->img_height;
g_clear_pointer (&self->image_bits, g_free);
self->image_bits = g_malloc0 (self->expected_image_size * 2); self->image_bits = g_malloc0 (self->expected_image_size * 2);
} }