mirrors/libfprint
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libfprint/libfprint.git synced 2026-06-11 02:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-fp-todv1-types: Ensure we check all the enum values

Browse Source 
We were ignoring enum values when there were gaps, so let's check that
all the values in the old version enums are present in the current one.
This commit is contained in:
Marco Trevisan (Treviño)
2021-09-04 04:08:10 +02:00
parent 125d6e276f
commit 312b75fe66
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test-fp-todv1-types.c
+18 -7
View File
@@ -37,18 +37,26 @@ check_enum_compatibility (GType old_type, GType current_type)
g_autoptr(GEnumClass) current_class = g_type_class_ref (current_type);
int i;
g_debug ("Checking Enum %s", g_type_name (current_type));
g_debug ("Checking Enum %s vs %s",
g_type_name (current_type),
g_type_name (old_type));
g_assert_true (G_TYPE_IS_ENUM (old_type));
g_assert_true (G_TYPE_IS_ENUM (current_type));
g_assert_cmpuint (old_class->n_values, <=, current_class->n_values);
for (i = 0; g_enum_get_value (old_class, i); ++i)
for (i = old_class->minimum; i <= old_class->maximum; i++)
{
GEnumValue *old_value = g_enum_get_value (old_class, i);
GEnumValue *current_value = g_enum_get_value_by_nick (current_class,
old_value->value_nick);
GEnumValue *current_value;
g_debug (" .. %s", old_value->value_nick);
if (!old_value)
continue;
current_value = g_enum_get_value_by_nick (current_class,
old_value->value_nick);
g_debug (" .. %s (%d)", old_value->value_nick, old_value->value);
g_assert_nonnull (current_value);
g_assert_cmpuint (old_value->value, ==, current_value->value);
}
@@ -61,10 +69,13 @@ check_flags_compatibility (GType old_type, GType current_type)
g_autoptr(GFlagsClass) current_class = g_type_class_ref (current_type);
int i;
g_debug ("Checking Flags %s", g_type_name (current_type));
g_debug ("Checking Flags %s vs %s",
g_type_name (current_type),
g_type_name (old_type));
g_assert_true (G_TYPE_IS_FLAGS (old_type));
g_assert_true (G_TYPE_IS_FLAGS (current_type));
g_assert_cmpuint (old_class->n_values, <=, current_class->n_values);
for (i = 0; i < old_class->n_values; ++i)
{
@@ -72,7 +83,7 @@ check_flags_compatibility (GType old_type, GType current_type)
GFlagsValue *current_value = g_flags_get_value_by_nick (current_class,
old_value->value_nick);
g_debug (" .. %s", old_value->value_nick);
g_debug (" .. %s (%d)", old_value->value_nick, old_value->value);
g_assert_nonnull (current_value);
g_assert_cmpuint (old_value->value, ==, current_value->value);
}