Marco Trevisan (Treviño)
1789914aad
New upstream release
2020-12-10 13:55:34 +01:00
Marco Trevisan (Treviño)
6c8d013c9d
Update upstream source from tag 'upstream/1.90.6'
...
Update to upstream version '1.90.6'
with Debian dir b7eff36961
2020-12-10 13:45:13 +01:00
Marco Trevisan (Treviño)
cf4df8292e
New upstream version 1.90.6
2020-12-10 13:45:07 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
c02771d16b
goodixmoc: Add async identification test using on-owned deseralized prints
...
This simulates what fprintd does
2020-12-09 13:30:37 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
989d498eb9
goodix: Don't leak the templates array during verify
...
When verifying we initialize a temporary templates array but we never
release it.
2020-12-09 12:55:26 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
faade91c39
test-fpi-device: Add function to create fake FpPrint's and galleries
2020-12-09 11:47:33 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
0d9d7dcb46
fp-print: Don't deference the passed error, use g_set_error instead
...
It still may be NULL, but we don't protect from that.
2020-12-09 10:38:38 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
fb23f8690f
fp-print: Return NULL on error
...
not really different from FALSE, but still..
2020-12-09 10:38:38 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
6ca8441df9
umockdev-tests: Don't fail when trying to save other errors
2020-12-09 10:26:58 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
8112da0358
umockdev-tests: Still raise an error when storing the exception output
...
Otherwise we won't ever fail
2020-12-09 10:26:58 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
f2ea3e784e
fp-print: Delete not-defined anymore functions
2020-12-09 10:26:58 +01:00
Marco Trevisan (Treviño)
0688288c6d
.git-blame-ignore-revs: Ignore formatting commit and add hint how to use it
2020-12-07 19:01:10 +01:00
Marco Trevisan (Treviño)
c1e832e7a7
fp-device: Return valid finger status value on error
...
Not that the two enums have different value, but indeed the type is
wrong.
2020-12-04 12:15:22 +00:00
Marco Trevisan (Treviño)
b5496fd257
fp-device: Ensure finger status is set to proper type on property getter
...
Finger status is a flag not an enum.
Add tests.
2020-12-04 12:15:22 +00:00
Marco Trevisan (Treviño)
bb38a8c99c
debian/gbp.conf: Include suggested settings by GNOME team
...
Even if libfprint is not part of GNOME I think these settings are good
practice anyways.
2020-12-02 21:16:41 +01:00
Marco Trevisan (Treviño)
cb0eb5c5be
debian/rules: Increase testing timeout
...
As default might not be enough in some archs
2020-12-02 20:58:21 +01:00
Marco Trevisan (Treviño)
776c789533
debian: Switch to debhelper 13 and use its features
...
As per this restrict more the .install files wilcards
2020-12-02 20:58:21 +01:00
Marco Trevisan (Treviño)
899d5c309f
debian/rules: Enable tests in s390x as it now builds and tests correctly
2020-12-02 19:01:08 +01:00
Marco Trevisan (Treviño)
632a2abf62
Upload to unstable
2020-12-02 17:53:32 +01:00
Marco Trevisan (Treviño)
616dbcaad6
Update changelog
2020-12-02 17:52:57 +01:00
Marco Trevisan (Treviño)
0494815d57
Add myself to Uploaders
2020-12-02 17:52:11 +01:00
Marco Trevisan (Treviño)
4f85d9e1b3
debian/patches: Don't byte-swap two times the NBIS print array contents
...
Fixes virtual-image test in libfprint for s390x
2020-12-02 17:48:28 +01:00
Marco Trevisan (Treviño)
f58ac0a499
debian/patches: Properly handle identify return value and add tests
...
This fixes fprintd test failures in s390x
2020-12-02 17:47:37 +01:00
Marco Trevisan (Treviño)
de271a0e8d
fp-print: Don't byte-swap two times the NBIS array contents
...
When serializing an image print in big endian machine we ended up
swapping the arrays contents two times, first when adding the values and
eventually when calling g_variant_byteswap which already handles this
properly.
With this, we get the test passing into s390x.
Fixes : #236
2020-12-02 16:40:10 +00:00
Marco Trevisan (Treviño)
12b0120a3d
test-fpi-device: Always check the return values for the API calls
...
Ensure that the return value of the API calls match the expected one,
as we need to ensure that it also matches with the error/no-error case.
2020-12-02 16:28:36 +00:00
Marco Trevisan (Treviño)
2783ac3e60
fpi-device: Return proper type on identification success
...
Identify function is supposed to propagate a boolean value, but we make
it return an integer instead on idle, this can be normally the same in
most of architectures, but not in BE ones.
So, make it return the proper type.
Fixes test failures in s390x.
Related to #236
2020-12-02 16:28:36 +00:00
Marco Trevisan (Treviño)
5cc6a64502
Upload to unstable
2020-12-02 05:11:33 +01:00
Marco Trevisan (Treviño)
6a22714677
Update changelog
2020-12-02 05:09:33 +01:00
Marco Trevisan (Treviño)
457f8c818c
debian/patches: Use gbp pq topics for debian-specific patches
2020-12-02 05:09:33 +01:00
Marco Trevisan (Treviño)
e696d77514
New upstream release
2020-12-02 04:57:16 +01:00
Marco Trevisan (Treviño)
c083be9ed6
Update upstream source from tag 'upstream/1.90.5'
...
Update to upstream version '1.90.5'
with Debian dir af3de02221
2020-12-02 04:53:48 +01:00
Marco Trevisan (Treviño)
5f93ff8536
New upstream version 1.90.5
2020-12-02 04:53:44 +01:00
Marco Trevisan (Treviño)
2b7cfa751a
list-udev-rules: Remove Wrongly added well-known USB controller vid/pid combo
...
This was causing USB controllers to use power-saving mode, breaking usb
devices usage.
Related to: https://gitlab.freedesktop.org/libfprint/libfprint/-/issues/327
2020-11-30 20:03:32 +01:00
Marco Trevisan (Treviño)
b27542b02e
Update changelog
2020-11-30 19:58:52 +01:00
Marco Trevisan (Treviño)
c595b5b170
debian/libfprint-2-2.symbols: Add new symbols
2020-11-27 16:48:03 +01:00
Marco Trevisan (Treviño)
71676bd2e8
debian/rules: Also build the virtual drivers, as they're useful for testing
...
Mostly it allows testing fprintd fully.
2020-11-27 16:35:08 +01:00
Marco Trevisan (Treviño)
aff0fe6553
Update upstream source from tag 'upstream/1.90.4'
...
Update to upstream version '1.90.4'
with Debian dir 1ef71fb7ce
2020-11-27 16:28:28 +01:00
Marco Trevisan (Treviño)
480451d784
New upstream version 1.90.4
2020-11-27 16:28:21 +01:00
Marco Trevisan (Treviño)
fa3bdb874d
udev-rules: Regenerate from wiki to include VFS495
2020-11-25 18:28:41 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
dda3587b76
identify: Use stored print to show identify information
...
The stored print may contain more metadata, so let's use that for
device-stored print, if available.
2020-11-23 17:00:01 +00:00
Marco Trevisan (Treviño) and Benjamin Berg
fb5854213a
examples: Add Identify example
...
It was the only main action left in the examples, we use the gallery
from the device if available, otherwise the local one.
2020-11-23 17:00:01 +00:00
Marco Trevisan (Treviño)
251ccef9ba
fpi-device: Add debug information about the enrolled finger
2020-11-08 22:19:23 +01:00
Marco Trevisan (Treviño)
3b993fabb6
verify/enroll: Save and use locally saved prints also for devices with storage
...
Some devices have storage but that's is limited enough not to be able
to store all the metadata, but just a fingerprint id.
In such case we also need to use the local storage to be able to verify.
Fprintd does this already, but we don't do it in the libfprint examples.
So, in in case we enroll, always save the print information to the disk,
while in case we verify we try to load the print from disk and we use
that in case its private data matches the one provided by the device.
2020-11-08 22:19:23 +01:00
Marco Trevisan (Treviño)
0c56e0de6d
synaptics: Report finger status to libfprint
...
The inactivation in case would be set back by libfprint
2020-11-07 13:23:30 +00:00
Marco Trevisan (Treviño)
893ff9c033
fp-image-device: Report finger status changes to the device
...
While the image device has its own finger status tracking, we use a simpler
version as public data information, so let's just report the finger-on/off
and when a finger is expected to the parent class.
Verify that this happens as expected using the virtual-image class
2020-11-07 13:23:30 +00:00
Marco Trevisan (Treviño)
3c382cac7f
fp-device: Reset the finger status on complete
...
Devices should handle the finger status internally, but if they don't do it
we need to handle it on actions completion
2020-11-07 13:23:30 +00:00
Marco Trevisan (Treviño)
42e4506b1b
fp-device: Add finger-status property
...
It can be used by drivers to report the state of the finger on sensor
2020-11-07 13:23:30 +00:00
Marco Trevisan (Treviño)
dc0371256f
debian/rules: Be strictier about symbol changes
2020-06-19 17:35:01 +02:00
Marco Trevisan (Treviño)
7c359b9135
Update changelog
2020-06-19 16:17:54 +02:00
Marco Trevisan (Treviño)
7b9a8e0dfb
git_reading_pointer.patch: Dopping
2020-06-19 16:17:54 +02:00
Marco Trevisan (Treviño)
2ba95f2ad5
Update upstream source from tag 'upstream/1.90.2'
...
Update to upstream version '1.90.2'
with Debian dir b87656b655
2020-06-19 15:48:35 +02:00
Marco Trevisan (Treviño)
748bfa09ce
New upstream version 1.90.2
2020-06-19 15:48:26 +02:00
Marco Trevisan (Treviño)
b7e27bfdc6
demo: Handle the non-imaging mode also if we get a non-supported error
...
Image devices may return a FP_DEVICE_ERROR_NOT_SUPPORTED error once capture
is already started, in such case handle the error going in non imaging mode
2020-06-17 14:16:34 +02:00
Marco Trevisan (Treviño)
37b19674f1
verify: Use fast matching callback also for non-storage devices
2020-06-17 14:14:50 +02:00
Marco Trevisan (Treviño)
a5f4ad507a
img-capture: Exit with error if the device doesn't support capture
2020-06-17 14:12:43 +02:00
Marco Trevisan (Treviño)
1f96077e36
examples: Don't try to save an image from a print without it
...
A device may produce both prints with image data and not, so only do it
in the case the prints contains image data
2020-06-17 14:00:19 +02:00
Marco Trevisan (Treviño)
ed26976ac5
fpi-usb-transfer: Use the same values of libusb for transfer types
2020-06-16 22:50:47 +02:00
Marco Trevisan (Treviño)
e4d292b595
fp-image-device: Properly include fp-device.h
2020-06-16 22:49:38 +02:00
Marco Trevisan (Treviño)
c6b8430c72
fpi-print: Improve debug on print score
2020-06-16 22:49:18 +02:00
Marco Trevisan (Treviño)
cbf1dcca29
fpi-image-device: Improve debugging messages
2020-06-16 22:48:51 +02:00
Marco Trevisan (Treviño)
7f7d099ba0
fpi-device: Don't double check for cancellable value
...
g_cancellable_is_cancelled already handles properly null values
2020-06-16 22:43:18 +02:00
Marco Trevisan (Treviño)
b6f965c1d9
fpi-device: Use the current action string instead of value
2020-06-16 22:42:34 +02:00
Marco Trevisan (Treviño)
bc3f622b2a
context: Factorize duplicated code
2020-04-24 20:21:01 +02:00
Marco Trevisan (Treviño)
5de49b33e6
image-device: Terminate the current action with error on print failure
...
If we fail when setting the scanned image to a print, we'll have a fatal
error, in such case we can terminate the current action and deactivate the
device.
2020-04-24 20:09:56 +02:00
Marco Trevisan (Treviño)
81e198c034
image: Return an error if we got an empty or NULL minutiae array
...
In some cases nbim's get_minutiae returns no minutiae without providing an
error code, and if this happens we would crash in the task callback function
as we would try to deference the data->minutiae pointer.
Related to: #251
2020-04-24 20:09:56 +02:00
Marco Trevisan (Treviño)
c0895a858d
etes603: Return TOO_SHORT retry error for small images
...
If the image height is less than the sensor horizontal resolution, then
return a retry error rather than trying to submit the image for further
processing.
Related to: #251
2020-04-24 20:03:51 +02:00
Marco Trevisan (Treviño)
41e05b1133
test-fpi-device: Don't compare error pointers that have been cleared
...
During verify/identify complete we replace the error pointer that the driver
returned with another error we created, after clearing that one.
However, when we initialize a new error the compiler may reuse the same
allocation of the cleared one, and this might lead to a test failure.
So, don't be so fragile and ignore the pointer check
2020-04-15 14:19:53 +02:00
Marco Trevisan (Treviño)
e7ff4f705c
tests: Import FPrint only during execution not when parsing
...
The unittest_parser script would try to import FPrint gi module, but it
would fail as per the fact that none is installed yet, so make sure that
we don't load any FPrint module until we try to actually run the tests
2020-03-27 21:19:09 +00:00
Marco Trevisan (Treviño)
c26588942a
ci: Print coverage data once available so that gitlab can parse it
2020-03-27 00:00:07 +01:00
Marco Trevisan (Treviño)
2ae8b74e60
meson: Add fpi-compat.h to the private headers
2020-02-27 06:03:21 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
0bb8ad1313
tests: Make meson be aware of the single python unit tests
...
Scan for the unit tests in virtual-image suite and handle them individually
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
6eb06697e9
tests/virtual-image: Use introspection names for errors
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
355cae1bbd
fp-device: Return error if trying to list a storage-less device
...
Devices with no storage don't allow listing prints, and if we try to do
that, we'd end up in trying to call a NULL function pointer, causing a crash
So always check if the device has storage before calling the list vfunc, and
if we fail, return an error.
Include an unit-test to verify this situation
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
15a90eb451
meson: Use gnu99 as default C standard
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
82ba69b1df
meson: Depends on gusb 0.2.0, but only enable tests on 0.3.0
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
ccd42bdece
gitignore: Remove autotools ignores, add _build
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
5faf8498d9
compat: Use new GDate autoptr and define if needed
2020-02-10 11:41:40 +01:00
Marco Trevisan (Treviño) and Benjamin Berg
cfbd5d27b7
comapt: Add FpDeviceClass compatibility autoptr and use it
2020-02-10 11:41:37 +01:00
Marco Trevisan (Treviño)
bb08d2e3c2
ci: Use extends to define extra libfprint variables
...
This allows to merge the values when included instead of replacing the whole
variables stanza.
2020-02-05 20:00:07 +01:00
Marco Trevisan (Treviño)
ca5143ffa5
ci: Exclude flatpak job from the schedules
2020-02-05 19:37:42 +01:00
Marco Trevisan (Treviño)
7eb10178b8
ci: Use a template to define libfprint dependencies
...
This allows to share the configuration with fprintd
2020-02-05 18:04:00 +01:00
Marco Trevisan (Treviño)
2c9e252ca4
meson: Use versioned name for autosuspend udev rules
...
Given distros may have the previous value around, let's rename this too
2020-01-23 17:25:38 +01:00
Marco Trevisan (Treviño)
23fab3a20a
Change SONAME and all the library paths to libfprint-2
...
To avoid conflicts with previous libfprint version and make sure that the
target version is the correct one (plus to allow parallel install in some
distros), let's use a versioned naming for the library keeping the abi
version in sync.
Fixes #223
2020-01-23 17:09:58 +01:00
Marco Trevisan (Treviño)
24e9363a46
doc/meson: Use ignore_headers instead of scan_args
2020-01-23 17:00:08 +01:00
Marco Trevisan (Treviño)
a12d316aa4
meson: Use project name for log domain
2020-01-23 17:00:04 +01:00
Marco Trevisan (Treviño)
3b47113122
synaptics: Immediately complete verification if finger removed
...
When quickly scanning a finger with the synaptic driver, it may wait forever
for finger removal even if this has already happened.
In fact we don't take care of the finger status when reporting the
verification.
To avoid this, add a function that delays the completion of the verification
until the finger removal if the finger is on sensor, otherwise it just
performs it.
Fixes #228
2020-01-20 18:24:16 +00:00
Marco Trevisan (Treviño)
7a7bec5a80
synaptics: Report a verify complete error on unexpected result
...
Also remove the unneeded verify report with match failure
2020-01-20 18:24:16 +00:00
Marco Trevisan (Treviño)
8be861b876
synaptics: Remove unneeded complete error/data parameters
...
Remove the never-used cmd_complete_data value and the repetition of
cmd_complete_error.
In fact now as per the fpi_device_verify_report() usage, we already pass
the match information to the device, such as the error and it will be
they will be used on completion if needed.
This allows to simplify cmd_ssm_done() as well.
2020-01-20 18:24:16 +00:00
Marco Trevisan (Treviño)
8893840ffa
synaptics: Always report verify state early on non-match
...
In some cases we want to complete the verification after that the finger has
been removed, but we still need to promptly report the match state otherwise
fpi-device will complain about, and will eventually cause a match error
instead that reporting a non-match:
synaptics: Finger is now on the sensor
synaptics: Received message with 0 sequence number 0x91, ignoring!
synaptics: interrupt transfer done
synaptics: delaying match failure until after finger removal!
synaptics: interrupt transfer done
device: Driver reported successful verify complete but did not report the
result earlier. Reporting error instead
libfprint: Failed to verify print: An unspecified error occured!
Fixes #227
2020-01-20 18:24:16 +00:00
Marco Trevisan (Treviño)
4d6a7ec09d
synaptics: Really check if a print is device database
...
Fix a typo causing the not-in-database print error to be fired, actually
checking the response result.
2020-01-20 18:24:16 +00:00
Marco Trevisan (Treviño)
05df5e2822
test-fpi-device: Verify driver enroll errors
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
58a9214610
test-fpi-device: Add tests for verify/identify warnings
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
cdcc476325
examples/verify: Prompt match/no-match report in callback
...
Promptly show the match/no-match result in the match callback instead of
waiting the verification process to be finished.
Also exit in case of an hard error, while permit to try again in case of a
retry error.
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
a87e9c546f
test-fpi-device: Verify device action error operations
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
ad514c3775
test-fpi-device: Fix file description
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
3c5b7f8ea6
test-fpi-device: Add more probe tests with errors
2020-01-17 19:44:52 +01:00
Marco Trevisan (Treviño)
b09df0e40a
test-fpi-device: Add tests for error message creation
2020-01-17 19:44:50 +01:00
Marco Trevisan (Treviño)
027ac8d843
fpi-device: Only mark a device as closed if the operation succeeded
...
We may fail during the close phase, in such case the device should not be
marked as closed.
2020-01-17 19:03:33 +01:00
Marco Trevisan (Treviño)
b3a4c2cf9a
fpi-device: Improve logging and testing on report/complete
2020-01-17 19:03:33 +01:00
Marco Trevisan (Treviño)
9f3272f296
test-fpi-device: Use smart pointer to handle CB data
2020-01-17 18:43:01 +01:00